Re: WARNS = 2, sbin/ping...

"Jacques A. Vidrine" <[email protected]> Wed, 5 Mar 2003 07:34:08 -0600
Newsgroups gmane.os.freebsd.devel.audit
Message-ID <[email protected]>
On Tue, Mar 04, 2003 at 07:39:02PM -0800, Sean Chittenden wrote:
> > Speaking of WARNS2, here's a patch that bumps ping(8) to WARNS2.  Once
> > upon a tie it used to be WARNS5, but the patch has rotted some.  The
> > biggie in this one was collisions with sin(3) and sockaddr_in variable
> > sin.  -sc
> 
> Follow up post.  Does the WARNS=2 cleanup of ping look alright?  A
> slightly updated version of the patch is at the following URL:
> 
> http://people.freebsd.org/~seanc/patches/#ping_warns_2
> 
> I've been using this for over a month and the patch above has been
> updated to include recent IPSEC changes.  -sc
> 

It looks good to me, except for the string literal concatenation bit
(but that's probably flamewar material anyway).

Cheers,
-- 
Jacques A. Vidrine <[email protected]>          http://www.celabo.org/
NTT/Verio SME          .     FreeBSD UNIX     .       Heimdal Kerberos
[email protected]     .  [email protected]  .          [email protected]

To Unsubscribe: send mail to [email protected]
with "unsubscribe freebsd-audit" in the body of the message