Re: /bin/sh flag NO_HISTORY

On Mon, Mar 17, 2003 at 02:11:53PM -0600, Guy Helmer wrote:
> --- /usr/src/bin/sh/Makefile	Mon Mar 17 10:38:03 2003
> +++ Makefile	Mon Mar 17 10:34:07 2003
> @@ -14,8 +14,12 @@
>  # utilities of the same name are handled with the associated manpage,
>  # builtin.1 in share/man/man1/.
> 
> +.if !defined(NO_HISTORY)
>  DPADD+= ${LIBL} ${LIBEDIT} ${LIBTERMCAP}
>  LDADD+= -ll -ledit -ltermcap
> +.else
> +CFLAGS+=-DNO_HISTORY
> +.endif

Could you please do this the other way around:
.if defined(NO_HISTORY)
CFLAGS+=-DNO_HISTORY
.else
DPADD+= ${LIBL} ${LIBEDIT} ${LIBTERMCAP}
LDADD+= -ll -ledit -ltermcap
.endif

I think double negations don't add in readbility.

-Guido

To Unsubscribe: send mail to [email protected]
with "unsubscribe freebsd-audit" in the body of the message