Re: realpath(3)

Johan Karlsson <[email protected]> Tue, 13 May 2003 09:34:11 +0200
Newsgroups gmane.os.freebsd.devel.audit
Message-ID <[email protected]>
Hi

On Mon, May 12, 2003 at 22:58 (+0700) +0000, Max Khon wrote:
> hi, there!
> 
> I am going to MFC realpath(3) and would like to get another round of
> review before MFC. Please look at
> 
> http://www.freebsd.org/cgi/cvsweb.cgi/src/lib/libc/stdlib/realpath.c?rev=1.19&content-type=text/x-cvsweb-markup

There are three realy minor things found by trying to make the code 
WARNS=6 clean.

The comparisions on line 94 and line 173 comapares unsigned versus
signed. 

The variable 'symlink' shadows a function from unistd.h
and should be chnaged.

Thanks for doing the MFC.

/Johan K


> 
> /fjoe
> 
> _______________________________________________
> [email protected] mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-audit
> To unsubscribe, send any mail to "[email protected]"

-- 
Johan Karlsson		mailto:[email protected]
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-audit
To unsubscribe, send any mail to "[email protected]"