Re: bin/56502

"Brian F. Feldman" <[email protected]> Mon, 06 Oct 2003 20:24:32 -0400

Newsgroups	gmane.os.freebsd.devel.audit
Message-ID	<[email protected]>

I don't see any errors; there is a part that seems unnecessary, and a couple 
places that have/don't have spaces where they would be preferred (so these 
are just style issues anyway, not very important):
    -           state[-1] = MAX_TYPES * (rptr - state) + rand_type;
    +           state[-1] = MAX_TYPES * (uint32_t)(rptr - state) + rand_type;
I believe that you don't need to cast in that situation, that you will get a 
compatible size_t or something close to that.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> [email protected]                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\


_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-audit
To unsubscribe, send any mail to "[email protected]"