Re: svn commit: r45522 - head/share/xml

Glen Barber <[email protected]> wrote
  in <[email protected]>:

gj> On Wed, Aug 27, 2014 at 06:18:28AM +0900, Hiroki Sato wrote:
gj> > Glen Barber <[email protected]> wrote
gj> >   in <[email protected]>:
gj> >
gj> > gj> Author: gjb
gj> > gj> Date: Tue Aug 26 20:47:16 2014
gj> > gj> New Revision: 45522
gj> > gj> URL: http://svnweb.freebsd.org/changeset/doc/45522
gj> > gj>
gj> > gj> Log:
gj> > gj>   Add more missing manual pages from head/, stable/10/, and
gj> > gj>   stable/9/ that were excluded from the previous change
gj> > gj>   because of local make.conf(5) and src.conf(5) entries.
gj> >
gj> > gj> +<!ENTITY man.atf-c++-api.3 "<citerefentry xmlns='http://docbook.org/ns/docbook'><refentrytitle>atf-c++-api</refentrytitle><manvolnum>3</manvolnum></citerefentry>">
gj> >
gj> >  An entity name needs to be in a [:_a-zA-Z][-.a-zA-Z0-9]* format in
gj> >  US-ASCII.
gj> >
gj>
gj> Hmm, it passed my build test until I did 'make clean'. :(
gj>
gj> Fixed, sorry about the breakage.

 No problem.  You might want to fix the substitution in
 share/exmaples/missing-manrefs.sh:

gj> +			_m=$(echo ${_m} | sed -e 's,\./,,')
gj> +			_m=$(echo ${_m} | sed -e 's/_/./g')

 And I think you should add a copyright notice into
 missing-manrefs.sh.  Without it, "... the above copyright notice ..."
 in the two clauses do not make sense.

-- Hiroki

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEABECAAYFAlP9ZcwACgkQTyzT2CeTzy3UVACeIpK6SMDuNA1qB4xuE44uRw1t
NdMAoNodlSDWxOLbXqfAAAwADc7j0h50
=MQjj
-----END PGP SIGNATURE-----