Re: git: 5476df45eb - main - 13.0R/relnotes: Add entries for changes that happened in bhyve.

John Baldwin <[email protected]>
Newsgroups gmane.os.freebsd.devel.cvs.doc
Message-ID <[email protected]>
On 2/10/21 8:19 PM, Daniel Ebdrup Jensen wrote:
> The branch main has been updated by debdrup:
> 
> URL: https://cgit.FreeBSD.org/doc/commit/?id=5476df45eb064fc3bdd7172ce9f38822eb143307
> 
> commit 5476df45eb064fc3bdd7172ce9f38822eb143307
> Author:     Daniel Ebdrup Jensen <[email protected]>
> AuthorDate: 2021-02-10 04:32:24 +0000
> Commit:     Daniel Ebdrup Jensen <[email protected]>
> CommitDate: 2021-02-11 04:18:46 +0000
> 
>      13.0R/relnotes: Add entries for changes that happened in bhyve.
>      
>      While here, implement a template for cgit links called 'commit' for lack
>      of a better term.
>      
>      This fixes the only build issue with this patch, and has been tested in
>      Firefox with the run target as well.

Hmm, can you make 'commit' configurable so it doesn't hardcode the src repository?
E.g. can it take an optional 2nd arg (which defaults to 'src') which is the repo?

I think it would also be good if it was 'githash' or the like as that's a bit more
future proof should we have to change to something else in the future.  (The
old XML shortcut for this was named githash for precisely that reason.)

It might also be nice if we could provide the full hash and centralize the
abbreviation logic in the keyword so that if we eventually have to expand the
prefix as our history grows we can fix that in one place and rebuild the docs
without having to go fix all the actual places that use the keyword.

-- 
John Baldwin
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/dev-commits-doc-all
To unsubscribe, send any mail to "[email protected]"
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.