Re: git: dc29678709b9 - main - ports-mgmt/pkg: update to 2.8.0

"Herbert J. Skuhra" <[email protected]> Sat, 01 Aug 2026 13:54:08 +0200
Newsgroups gmane.os.freebsd.devel.cvs.ports
Message-ID <[email protected]>
On Sat, 1 Aug 2026, at 13:21, Po-Chuan Hsieh wrote:
> Hello Baptiste,
>
> On Mon, Jul 20, 2026 at 5:25 PM Baptiste Daroussin <[email protected]> wrote:
>
>> The branch main has been updated by bapt:
>>
>> URL:
>> https://cgit.FreeBSD.org/ports/commit/?id=dc29678709b9e811de8efab97d22e493f4cc3777
>>
>> commit dc29678709b9e811de8efab97d22e493f4cc3777
>> Author:     Baptiste Daroussin <[email protected]>
>> AuthorDate: 2026-07-20 09:18:22 +0000
>> Commit:     Baptiste Daroussin <[email protected]>
>> CommitDate: 2026-07-20 09:23:50 +0000
>>
>>     ports-mgmt/pkg: update to 2.8.0
>
>  [...]
>
>> diff --git a/ports-mgmt/pkg/Makefile b/ports-mgmt/pkg/Makefile
>> index 2b1abd1d506e..c255a3ddcc29 100644
>> --- a/ports-mgmt/pkg/Makefile
>> +++ b/ports-mgmt/pkg/Makefile
>> @@ -53,8 +53,8 @@ PKG_BIN=      ${WRKSRC}/src/pkg-static
>>  .endif
>>
>>  post-install:
>> +       ${INSTALL_DATA} ${WRKSRC}/src/pkg.conf.sample
>> ${STAGEDIR}${PREFIX}/etc/
>>         @${MKDIR} ${STAGEDIR}${PREFIX}/lib/compat/pkg
>> -       ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libpkg.so
>> ${STAGEDIR}${PREFIX}/sbin/pkg*
>>
>
> Is it intentional to remove the STRIP_CMD command?
> May I reapply 236ce023bd14008e44bb91ea3222f8950942d78f?
> Thanks.

The strip command is not correct, is it?

Without:

$ ls -l work/stage/usr/local/lib/libpkg.so*
lrwxr-xr-x  1 root wheel      11 Aug  1 13:47 work/stage/usr/local/lib/libpkg.so -> libpkg.so.4
-rw-r--r--  1 root wheel 3731992 Aug  1 13:47 work/stage/usr/local/lib/libpkg.so.4

With:

$ ls -l work/stage/usr/local/lib/libpkg.so*
-rw-r--r--  1 root wheel 3333216 Aug  1 13:50 work/stage/usr/local/lib/libpkg.so
-rw-r--r--  1 root wheel 3731992 Aug  1 13:50 work/stage/usr/local/lib/libpkg.so.4

Maybe use 

${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libpkg.so.* ${STAGEDIR}${PREFIX}/sbin/pkg*
or
${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libpkg.so.? ${STAGEDIR}${PREFIX}/sbin/pkg*

instead?