git: a4b5ff57ef85 - stable/15 - ktimer: Check for errors from realtimer_gettime()

Mark Johnston <[email protected]>
Newsgroups gmane.os.freebsd.devel.cvs.src
Message-ID <6a67ae35.3948b.23ff8c9a__47024.1947843292$1785179791$gmane$org@gitrepo.freebsd.org>
The branch stable/15 has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=a4b5ff57ef85031ba52feb70c754ba77f7c92cb0

commit a4b5ff57ef85031ba52feb70c754ba77f7c92cb0
Author:     Mark Johnston <[email protected]>
AuthorDate: 2026-07-17 13:08:33 +0000
Commit:     Mark Johnston <[email protected]>
CommitDate: 2026-07-27 17:34:32 +0000

    ktimer: Check for errors from realtimer_gettime()
    
    clock_gettime(CLOCK_TAI) can fail, leaving *ovalue uninitialized.
    
    Reported by:    Hazley Samsudin of GovTech CSG
    MFC after:      3 days
    Sponsored by:   The FreeBSD Foundation
    Differential Revision:  https://reviews.freebsd.org/D58225
    
    (cherry picked from commit 2f1ec7d159cbe56d40e7b6d7fc4188c9079e1783)
---
 sys/kern/kern_time.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/sys/kern/kern_time.c b/sys/kern/kern_time.c
index 2cbb88a15b24..4b53561bc522 100644
--- a/sys/kern/kern_time.c
+++ b/sys/kern/kern_time.c
@@ -1633,8 +1633,11 @@ realtimer_settime(struct itimer *it, int flags, struct itimerspec *value,
 		timespecclear(&val.it_interval);
 	}
 
-	if (ovalue != NULL)
-		realtimer_gettime(it, ovalue);
+	if (ovalue != NULL) {
+		error = realtimer_gettime(it, ovalue);
+		if (error != 0)
+			return (error);
+	}
 
 	it->it_time = val;
 	if (timespecisset(&val.it_value)) {
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.