Re: git: dd235f097af4 - main - route(8): Add prefsrc option in netlink

Kyle Evans <[email protected]> Fri, 31 Jul 2026 12:00:07 -0500
Newsgroups gmane.os.freebsd.devel.cvs.src
Message-ID <4e6ba52d-33f4-4af7-867c-c62547dcdc16__11567.5123337255$1785517220$gmane$org@FreeBSD.org>
On 7/31/26 11:59, Kyle Evans wrote:
> On 7/31/26 11:05, Pouria Mousavizadeh Tehrani wrote:
>> Hi Shawn,
>>
>> On 7/31/26 19:28, Shawn Webb wrote:
>>> Hey Pouria,
>>>
>>> This commit causes /sbin/route to crash. I will work on getting a core
>>> dump this weekend. Reverting this commit made /sbin/route happy again.
>>> I just figured I'd send the email now while I'm thinking about it.
>>>
>>> Note that I'm using HardenedBSD, so the core dump might be a little
>>> bit different than one generated by FreeBSD.
>>>
>>> Thanks,
>>>
>>
>> Thank you for the report.
>> I'll keep an eye out for your email.
>>
> 
> It seems like this should be predicated on `prefsrc != NULL`:
> 
> ```
> snl_add_msg_attr_ip(&nw, RTA_PREFSRC, prefsrc);
> ```
> 
> snl_add_msg_attr_ip seems like it'd be happy to dereference `prefsrc`, and
> we might not have one?
> 
> Thanks,
> 
> Kyle Evans
> 

Ahh, I see the follow-up now.