git: a86d65b2c99b - main - e1000: Avoid a signed multicast bitmap shift

Kevin Bowling <[email protected]>
Newsgroups gmane.os.freebsd.devel.cvs.src
Message-ID <6a7b8d4b.36b57.6ee63e90__32858.9180646063$1786482061$gmane$org@gitrepo.freebsd.org>
The branch main has been updated by kbowling:

URL: https://cgit.FreeBSD.org/src/commit/?id=a86d65b2c99bab3fe46389b3b51ad27956dccfe9

commit a86d65b2c99bab3fe46389b3b51ad27956dccfe9
Author:     Kevin Bowling <[email protected]>
AuthorDate: 2026-08-11 19:00:51 +0000
Commit:     Kevin Bowling <[email protected]>
CommitDate: 2026-08-11 20:59:32 +0000

    e1000: Avoid a signed multicast bitmap shift
    
    The multicast hash bit can be 31.  Use an unsigned value so setting the
    bit cannot shift a signed integer into its sign bit.
    
    MFC after:      2 weeks
---
 sys/dev/e1000/e1000_mac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/e1000/e1000_mac.c b/sys/dev/e1000/e1000_mac.c
index eb2c29d153dc..46e91773c126 100644
--- a/sys/dev/e1000/e1000_mac.c
+++ b/sys/dev/e1000/e1000_mac.c
@@ -611,7 +611,7 @@ void e1000_update_mc_addr_list_generic(struct e1000_hw *hw,
 		hash_reg = (hash_value >> 5) & (hw->mac.mta_reg_count - 1);
 		hash_bit = hash_value & 0x1F;
 
-		hw->mac.mta_shadow[hash_reg] |= (1 << hash_bit);
+		hw->mac.mta_shadow[hash_reg] |= 1U << hash_bit;
 		mc_addr_list += (ETHER_ADDR_LEN);
 	}
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.