git: 392fbdcf2232 - main - e1000: Avoid a signed manageability VLAN bitmap shift
Kevin Bowling <[email protected]>
| Newsgroups | gmane.os.freebsd.devel.cvs.src |
|---|---|
| Message-ID | <6a7b8d59.3775b.3a56f401__5478.33817997656$1786482222$gmane$org@gitrepo.freebsd.org> |
The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=392fbdcf2232f12cb973d00ae931740c72d970c6 commit 392fbdcf2232f12cb973d00ae931740c72d970c6 Author: Kevin Bowling <[email protected]> AuthorDate: 2026-08-11 19:36:20 +0000 Commit: Kevin Bowling <[email protected]> CommitDate: 2026-08-11 20:59:33 +0000 e1000: Avoid a signed manageability VLAN bitmap shift A manageability VLAN can select bit 31 of its VFTA register. Use an unsigned value when constructing the register mask. MFC after: 2 weeks --- sys/dev/e1000/e1000_82571.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/e1000/e1000_82571.c b/sys/dev/e1000/e1000_82571.c index 3621f35a819c..fa010075f367 100644 --- a/sys/dev/e1000/e1000_82571.c +++ b/sys/dev/e1000/e1000_82571.c @@ -1363,7 +1363,7 @@ static void e1000_clear_vfta_82571(struct e1000_hw *hw) E1000_VFTA_ENTRY_SHIFT) & E1000_VFTA_ENTRY_MASK; vfta_bit_in_reg = - 1 << (hw->mng_cookie.vlan_id & + 1U << (hw->mng_cookie.vlan_id & E1000_VFTA_ENTRY_BIT_SHIFT_MASK); } break;