Re: 1.2.1. FreeBSD installation process
Benedict Reuschling <[email protected]>
| Newsgroups | gmane.os.freebsd.devel.documentation |
|---|---|
| Message-ID | <[email protected]> |
Hello Alex, can you submit the patch as a unified diff (diff -u), which is teh preferred patch format that we use? You can also find more information on how to check your patch before submitting and the man pages editing process here: - https://docs.freebsd.org/en/books/fdp-primer/manual-pages/ Thank you! Regards, Benedict Am 01.05.26 um 05:31 schrieb [email protected]: > Attached is the mdoc file (/usr/share/man/man1/sh.1.gz) with the correction, sh2.1: > $ diff sh.1 sh2.1 > 34c34 > < .Dd May 1, 2025 > --- >> .Dd May 1, 2026 > 1878,1879c1878,1882 > < Pathname Expansion, > < the four varieties of parameter expansion for substring processing and the > --- >> Pathname Expansion. >> The four varieties of parameter expansion for substring processing are >> described above under >> .Sx Parameter Expansion . >> The > 1881c1884,1885 > < command. > --- >> command is described above under >> .Sx Flow-Control Constructs (if, while, for, case) . > $ > > Is it ok for 'submitting the patch'? > 'mandoc sh2.1' looks good to me. > > > > > > On Thu, Apr 30, 2026, at 8:14 AM, Matthew Seaman wrote: >> On 30/04/2026 12:47,[email protected] wrote: >>> I want to submit a patch for 'man sh' (/usr/share/man/man1/sh.1.gz). >>> Step 3 of '1.2.1 FreeBSD installation process' shows the following: >>> >>> 3. Edit the documentation files that require >>> changes. If a file needs major changes, >>> consult the mailing list for input. >>> >>> What is the documentation file for 'man sh'? >> https://github.com/freebsd/freebsd-src/blob/main/bin/sh/sh.1 >> >> Remember to update the date in the .Dd item right below the leading >> comment block. Also, only ever one sentence per line. If you're not >> familiar with how nroff macros work, or even if you are, opening a >> Phabricator review at reviews.freebsd.org would be a good idea, so you >> can get feedback from developers. >> >> Cheers, >> >> Matthew