[Bug 243178] newfs_msdos: wrong FAT type determination

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243178

--- Comment #7 from Damjan Jovanovic <[email protected]> ---
Created attachment 270974
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=270974&action=edit
automatically decreases cluster size to fit the minimum cluster count for the
FAT

This small patch automatically decreases cluster size to fit the minimum
cluster limit for the FAT. It works, but it's messy (overwriting
"bpbBigFATsecs" which can only be set once, "continue" to skip incrementing
"attempts" and recalculate values at least once more), and that whole long
complex region of code needs a lot of cleanup and refactoring.

NetBSD fixed this by setting the cluster size to 2, and then using a goto to
rerun the whole mkfs_msdos() function:
https://github.com/NetBSD/src/commit/410b25665f1249d5a02677564324f645c765596f

-- 
You are receiving this mail because:
You are the assignee for the bug.