[Bug 294925] nfs4 client error make FreeBSD panic

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=294925

Rick Macklem <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[email protected]              |[email protected]

--- Comment #6 from Rick Macklem <[email protected]> ---
Created attachment 271122
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=271122&action=edit
nfscl: Fix crashes caused by wrong struct field being used

Ouch! This is an embarrassing one.
It should be comparing with nd_sessionid
and not nd_sequence. (In this case, nd_sequence
would be NULL.)

When I looked, nd_sessionid wasn't even being
set properly, so this code "worked" by random luck
when nd_sequence was set to point to something.
(I have tested recovery in the past, so it did work?)
However, I only tested what you are seeing artificially,
because I didn't have a real way to get the code to
where you end up.

Anyhow, this patch should fix it.

I'll commit it right away and it should make it in 15.1
(Then I'll see about a 15.0 errata for it.)

Thanks for reporting this and figuring out where it
crashed in the sources. (I looked in this area when
it was first reported, but didn't spot the typo bug.)

-- 
You are receiving this mail because:
You are the assignee for the bug.