maintainer-feedback requested: [Bug 292877] editors/xed: update to 3.8.9

Bugzilla Automation <[email protected]> has asked freebsd-gnome (Nobody)
<[email protected]> for maintainer-feedback:
Bug 292877: editors/xed: update to 3.8.9
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292877



--- Description ---
- update to 3.8.9
- add pygobject3 to USE_GNOME. It was stated as a dependency in
https://github.com/linuxmint/xed/commit/13f55ff3f0db4e4f3b75883260bb56afbad08fd
2
and included into 3.8.6
https://github.com/linuxmint/xed/blob/3.8.9/debian/changelog#L23
- add NLS option, move gettext-tools to NLS_USES and enrich pkg-plist
- move things around a bit to pet portclippy (USE_LDCONFIG and USE_XORG)
- add a patch to fix build issue related to previous item. In the commit I
pointed above xed developers try to include proper girepository.h header based
on pygobject version. The problem in our case is that the build fails with the
following error:
...
In file included from ../xed/xed-app.c:42:
In file included from
/usr/local/include/glib-2.0/girepository/girepository.h:34:
In file included from /usr/local/include/glib-2.0/girepository/giarginfo.h:31:
/usr/local/include/glib-2.0/girepository/gitypes.h:41:28: error: typedef
redefinition with different types ('struct _GIBaseInfo' vs 'struct
_GIBaseInfoStub')
   41 | typedef struct _GIBaseInfo GIBaseInfo;
      | 			   ^
/usr/local/include/gobject-introspection-1.0/gitypes.h:44:3: note: previous
definition is here
   44 | } GIBaseInfo;
      |   ^
...
In file included from ../xed/xed-plugins-engine.c:40:
In file included from ../xed/xed-plugins-engine.h:35:
In file included from /usr/local/include/libpeas-1.0/libpeas/peas-engine.h:28:
In file included from
/usr/local/include/libpeas-1.0/libpeas/peas-extension.h:26:
In file included from
/usr/local/include/gobject-introspection-1.0/girepository.h:31:
In file included from
/usr/local/include/gobject-introspection-1.0/giarginfo.h:30:
/usr/local/include/gobject-introspection-1.0/gitypes.h:44:3: error: typedef
redefinition with different types ('struct _GIBaseInfoStub' vs 'struct
_GIBaseInfo')
   44 | } GIBaseInfo;
      |   ^
/usr/local/include/glib-2.0/girepository/gitypes.h:41:28: note: previous
definition is here
   41 | typedef struct _GIBaseInfo GIBaseInfo;
      | 			   ^
...

This happens because we have devel/libpeas1 version 1.36.0 which still includes
girepository.h header. In 1.38 they switched to girepository/girepository.h
header
https://github.com/GNOME/libpeas/commit/73e25b6059d2fdc090a3feb8341ff902c3ec0d1
6.
I can't upgrade devel/libpeas1 to 1.38+ as it requires newer devel/glib20. This
was my attempt:
...
Dependency glib-2.0 found: NO. Found 2.84.4 but need: '>= 2.85.0
...

So make xed switch back to include old girepository.h header by spoiling the
check and put a comment for future.
I added pygobject3 to USE_GNOME for future and to pass build check:
...
Run-time dependency pygobject-3.0 found: YES 3.54.5
...