gvfs patch to remove lsof dependency [review D56224]
Guido Falsi <[email protected]>
| Newsgroups | gmane.os.freebsd.devel.gnome |
|---|---|
| Message-ID | <[email protected]> |
Hi, As subject states I have prepared a patch to gvfs that removes the need to have lsof installed, replacing its usage with fuser(1), which is included in the base system. [1] I was moved into doing this after lsof broke (again) on head. There is a single use of lsof in gvfs, for which the port forces any desktop machine to depend on lsof. So I think this could be a very good improvement for our ports tree, removing this extra dependency, for a very single and minor use. I also sent the patch upstream [2], so if anyone has contacts there and can push for it or at least get some feedback that would be very helpful! Anyway, I am usually against diverging from upstream, but in this case I think the advantages are strong enough to warrant an exception. So I'm asking if anyone from gnome@ could approve this change. Thanks in advance! [1] https://reviews.freebsd.org/D56224 [2] https://gitlab.gnome.org/GNOME/gvfs/-/merge_requests/321 -- Guido Falsi <[email protected]>