Re: more pkgbase reviewers required

Pete Wright wrote in <[email protected]>:
> On 3/25/26 05:54, Lexi Winter wrote:
> > at this point, it's extremely difficult to get any pkgbase-related
> > changes reviewed in Phabricator, which is an issue since we're now
> > pushing pkgbase as the default method for installing the system.
> > [...]
>
> do you need to have a commit bit to be a useful reviewer.

no.  although... i will say i tend to give more attention to reviews
from other committers.  but it's not a requirement to be a committer
to review a change, and it's very helpful to get feedback from testing
(e.g., "this change broke my system!"), or to know that a particular
change might break existing deployments, for example.

but when considering whether to land a change, i only look at reviews
from committers.  i.e., i might *not* land a change if non-committers
have objections, but i will not land a change if the only reviews are
from non-committers.

does that make sense?  basically what i'm saying is, yes, it's useful
to get feedback on changes from people who aren't committers, but we
still need committers to actually land changes.

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSyjTg96lp3RifySyn1nT63mIK/YAUCacP2fAAKCRD1nT63mIK/
YOSeAPwJUIeL7VSOqt93vqyChnPhik8Cmitz8Lzz6HxICiNLpgEA/on8Pit4w+TW
2pGYhIHGXZcTjf9M9u0eTzuT1mnZDwE=
=C+dO
-----END PGP SIGNATURE-----