Re: Please revert b2e843161d
Andrew Turner <[email protected]> Thu, 25 Jun 2026 09:15:54 +0100
| Newsgroups | gmane.os.freebsd.devel.hackers |
|---|---|
| Message-ID | <[email protected]> |
> On 24 Jun 2026, at 19:58, Steve Kargl <[email protected]> wrote: > > Can someone with commit access please revert b2e843161dc3b? > > git log -r b2e843161dc3b79777e873183447c92ed9c3703a > Author: Andrew Turner <[email protected]> > Date: Tue Nov 2 11:31:17 2021 +0000 > > Use a builtin where possible in msun > > > If one has a libm built with, e.g., -DUSE_BUILTIN_FMAF, > and then tries to debug code that uses fmaf() where the > compiler options include -fno-builtin, a segfault > occurs. I suggest purging all of the recent additions > of USE_BUILTIN_*. These are simply not needed as a compiler > will use a builtin (if available) instead of a function from > libm. What architecture and compiler are you using to build libm? I only enabled it on arm64 as both llvm and gcc will generate the optimal assembly instruction. Other architectures and compilers the builtin may generate a call to fmaf creating an infinite loop. Andrew