Re: Ctype patch for review
"Petr Hroudný" <[email protected]>
| Newsgroups | gmane.os.freebsd.devel.internationalization |
|---|---|
| Message-ID | <[email protected]> |
2007/9/21, Andrey Chernov <[email protected]>: > On Wed, Sep 19, 2007 at 04:10:24PM +0400, Andrey Chernov wrote: > > Improved vesrsion. Intoduce general __mb_sch_limit parameter instead for > > all locales specifying upper limit of single char range. It allows also > > fix the bug when ctype(3) functions called with arg > 0xFF for wide > > character locales and simplifies all checks. New patch is attached. Here > > is updated rationale again: > > Next improved version, now optimized for speed. I decide to remove extra > _CTYPE_WID flag and duplicate needed functions instead. I believe your patch needs some adjustments for CJK charsets. You are setting __mb_sch_limit to 256 for all multibyte locales except UTF-8, but I believe it should be 128 also for Big5, GB18030, GBK. Regards, Petr _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-i18n To unsubscribe, send any mail to "[email protected]"