Re: page fault in isdn4bsd-kmod

Andreas Longwitz <[email protected]> Fri, 27 Apr 2018 12:14:09 +0200
Newsgroups gmane.os.freebsd.devel.isdn
Message-ID <[email protected]>
Hi Hans,

>>> (kgdb) f 12
>>> #12 0xc0c631b9 in cd_update (cd=0xc50cb920, pipe=0x0, event=11) at
>>> dss1_l3fsm.h:359
>>> 359             l2softc_t *sc = ((__typeof(pipe))(cd->pipe))->L5_sc;
>>> (kgdb) list
>>> 354      * NOTE: pipe might be zero!
>>> 355      */
>>> 356     static void
>>> 357     cd_update(call_desc_t *cd, DSS1_TCP_pipe_t *pipe, int event)
>>> 358     {
>>> 359             l2softc_t *sc = ((__typeof(pipe))(cd->pipe))->L5_sc;
>>> 360             __typeof(cd->state)
>>> 361               state = cd->state;
>>> 362
>>> 363             /*
>>>
> 
> Event 11 means EV_L3_RELEASE. It does not use the "sc" variable. I think
> different compilers might produce different results. However, the right
> solution is simply to ignore the "cd->pipe" being NULL in this case. It
> should be set in all the other cases where "sc" is used.
> 
> It might look like an outgoing call which was instantly hung up.
> 
> Can you try the attached patch?

Thanks for your patch, looks good. I will reboot my production server
today in the evening.

Andreas


_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-isdn
To unsubscribe, send any mail to "[email protected]"