Re: Call for testers: New acpi_ibm driver

On Tuesday 31 May 2005 19:24, Nate Lawson wrote:
> Markus Brueffer wrote:
> > On Tuesday 31 May 2005 03:55, [email protected] wrote:
> >>In message <[email protected]>, Markus Brueffer 
wrote:

[...]

> >>>Support for more hotkeys by the hotkey sysctl (see manpage)
> >>>Improved support of ACPI events, disabled by default. You can enable
> >>> it by setting the events sysctl to 1 (on my T41p there are now 24
> >>> different keypress events that get reported)
> >>>write support for: volume, mute, brightness and thinklight
> >>
> >>Is it ok to  touch EC? I know the two way of impliment it.
> >>One is modifying RTC register, another is using SMI interface
> >>via ACPI control method.
> >
> > Writing to the EC directly is nothing more that accessing the locations
> > via acpi_SetInteger. While I would highly prefer the latter method, the
> > problem is, that several places of the EC in the DSDT aren't even named
> > or only named on some models.
>
> Please do not read/write directly from EC space.  A better way is to use
> the EC device methods I added recently.  This uses proper locking for
> requests and will work concurrently with other EC users (say, cmbat):
>
>      device_t dev;
>
>      dev = devclass_get_device(devclass_find("acpi_ec"), 0);
>      if (dev == NULL)
>          error, EC not present -- check this during probe and fail
>          if error
>
>      error = ACPI_EC_WRITE(dev, address, buffer, len);
>
> or ACPI_EC_READ().  "address" is from 0-255 (8 bit addresses in EC
> space) and buffer is a pointer to data to write or read.

That's what I meant by "directly". The driver uses exactly that way.

Markus

-- 
Markus Brueffer    | GPG-Key: http://people.FreeBSD.org/~markus/markus.asc
[email protected] | FP: 3F9B EBE8 F290 E5CC 1447 8760 D48D 1072 78F8 A8D4
[email protected] | FreeBSD: The Power to Serve!

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (FreeBSD)

iD8DBQBCnKB91I0Qcnj4qNQRAlBFAJ43YD6iNXpE/XqWrEwqQJw5Uru7mACfdTC9
AF9WdHkfLdlojhl/yIF1V7o=
=Rlef
-----END PGP SIGNATURE-----