Re: Call for testers: New acpi_ibm driver

Hi Ruslan,

On Friday 10 June 2005 09:31, Ruslan Ermilov wrote:
> On Fri, Jun 10, 2005 at 01:31:03AM +0200, Markus Brueffer wrote:
> > thanks to everyone who has sent me the DSDT and/or tested the driver.
> > I have just committed the driver and manpage along with a port of tpb,a
> > utility that makes use of it:
>
> The attached patch fixes two bugs in the updated acpi_ibm(4) driver
> for my ThinkPad 600X, you have my ASL:
>
> - it doesn't have ThinkLight, so there's no real benefit from having
>   /dev/led/thinklight;

I have modified this part of the patch to only create the led(4) interface 
if write support for the thinklight is available. Reading through led(4) is 
not supported.

> - it doesn't have "cmos_handle", so acpi_ibm_sysctl_set() was using
>   uninitialized values of "val_ec" in ACPI_IBM_METHOD_VOLUME and
>   ACPI_IBM_METHOD_MUTE handlers, which resulted in volume to be
>   programmed incorrectly, and muting/unmuting would screw the
>   volume.

Fixed, thanks!

Markus

-- 
Markus Brueffer    | GPG-Key: http://people.FreeBSD.org/~markus/markus.asc
[email protected] | FP: 3F9B EBE8 F290 E5CC 1447 8760 D48D 1072 78F8 A8D4
[email protected] | FreeBSD: The Power to Serve!

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (FreeBSD)

iD8DBQBCqYE71I0Qcnj4qNQRAoueAJ0Ut7EdgU3m5KA28KiBJLa2I1wT1QCeOLxE
zfTdxOf89ReIiB41/I2Guio=
=vGAS
-----END PGP SIGNATURE-----