Re: galeon-1.2.9 gettext build problem

On Sat, 2003-04-12 at 10:02, Pav Lucistnik wrote:
> V so, 12. 04. 2003 v 12.49, Pav Lucistnik napsal:
> 
> > Hi, I'm updating Mozilla/Galeon on my 5.0-RELEASE system. Galeon
> > compilation bombs on undefined Lgettext:
> > 
> > ContentHandler.cpp: In member function `virtual nsresult 
> >    GContentHandler::PromptForSaveToFile(nsISupports*, const PRUnichar*,
> > const 
> >    PRUnichar*, nsILocalFile**)':
> > ContentHandler.cpp:367: `Lgettext' undeclared (first use this function)
> 
> > Problematic line is:
> > NS_NAMED_LITERAL_STRING (title, _("Select the destination filename"));
> 
> Tracked it down to macro expansion:
> 
> Mozilla header string/nsLiteralString.h defines:
> 
> #define NS_NAMED_LITERAL_STRING(n,s)
> NS_NAMED_MULTILINE_LITERAL_STRING(n, NS_LL(s))
> 
> and
> 
> #define NS_L(s) NS_LL(s)

Actually, it should be expanded by NS_LL, which is, in turn, expanded to
L##s (whatever).

> 
> so it looks like my compiler expands NS_NAMED_LITERAL_STRING macro, and
> then when looking how to expand NS_LL(s) macro it used NS_L(s) macro
> instead of desired NS_LL(s) macro...
> 
> My C++ skills ends here :( anyone can help? My gcc is stock from 5.0:
> 
> # c++ -v
> Using built-in specs.
> Configured with: FreeBSD/i386 system compiler
> Thread model: posix
> gcc version 3.2.1 [FreeBSD] 20021119 (release)
> 
> I don't have any non-standard options in /etc/make.conf

The Galeon people already fixed it.  I merged in their fix.  Thanks for
reporting!

Joe

-- 
PGP Key : http://www.marcuscom.com/pgp.asc

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)

iD8DBQA+mHrcb2iPiv4Uz4cRAsF5AJ0UPYbDBwwFfnsHaJdj6Bk+V6/yYQCfVA5d
HExO9uwzRzSr2UW+HJ3ZhiY=
=Wfo8
-----END PGP SIGNATURE-----