[Bug 255309] ice(4) driver doesn't use RSS option correctly

[email protected]
Newsgroups gmane.os.freebsd.devel.net
Message-ID <[email protected]/bugzilla/>
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255309

--- Comment #6 from [email protected] ---
A commit in branch stable/13 references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=2c6edd6dc94e7d429ce022262b9e25d159ce61e5

commit 2c6edd6dc94e7d429ce022262b9e25d159ce61e5
Author:     Brian Poole <[email protected]>
AuthorDate: 2024-10-11 19:57:52 +0000
Commit:     Mitchell Horne <[email protected]>
CommitDate: 2024-11-13 15:49:33 +0000

    ice(4): properly use kernel option RSS

    Header ice_rss.h uses the kernel RSS interface if option RSS is defined.
    However when ice_rss.h is included by ice_lib.h there is no prior
    inclusion of ice_opts.h to set RSS causing ifdef RSS to always fail. Add
    ice_opts.h to the top of ice_lib.h (like ice_iflib.h) so RSS can be
    defined when ice_rss.h is parsed.

    With that in place, compilation fails due to a missing defintion of
    ICE_DEFAULT_RSS_HASH_CONFIG. It is defined in ice_rss.h only when RSS is
    not defined. Since this define is not part of the kernel RSS interface
    but ice-specific, it should always be defined. Move its definition
    outside of ifdef RSS.

    PR:             255309
    Reviewed by:    mhorne, erj (earlier version)
    MFC after:      3 days
    Pull Request:   https://github.com/freebsd/freebsd-src/pull/1460

    (cherry picked from commit 6e5650896fe47398e49e3d81af60cc60dbb09e6e)

 sys/dev/ice/ice_lib.h |  3 +++
 sys/dev/ice/ice_rss.h | 16 ++++++++--------
 2 files changed, 11 insertions(+), 8 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.