[Bug 256579] arp(8) -S doesn't honour "blackhole" keyword

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256579

--- Comment #4 from Marek Zarychta <[email protected]> ---
Created attachment 265565
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=265565&action=edit
0001-arp-bring-back-reject-discard-functionalify-for-arp-.patch

Today, I retested the patch from https://reviews.freebsd.org/D32240, and it
appears to work correctly on stable/15. The original patch, rebased on the
recent HEAD, is uploaded here. I had to introduce only a small change in the
section below. To make it consistent with the recent version of the file
sys/net/if_llatbl.c "lltable_free_entry(llt, lle);" was added before "return
(EINVAL);".

+                       if (!discard) {
+                               if (!fill_lladdr(ifp, dst->sa_family, lle,
LLADDR(dl))) {
+                                       lltable_free_entry(llt, lle);
+                                       return (EINVAL);
+                               }
+                       } else {
+                               if (rtm->rtm_flags & RTF_REJECT)
+                                       lle->la_flags |= LLE_REJECT;
+                               else
+                                       lle->la_flags |= LLE_DISCARD;
+                               if (rtm->rtm_rmx.rmx_expire == 0)
+                                       lle->la_flags |= LLE_STATIC;
+                       }

Please refresh this review and commit this code if still applicable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.