[Bug 166724] if_re(4): watchdog timeout

[email protected] Sun, 19 Jul 2026 18:51:20 +0000
Newsgroups gmane.os.freebsd.devel.net
Message-ID <[email protected]/bugzilla/>
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D166724

--- Comment #140 from [email protected] ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=3Db0c14eae10609f7d688b31d112de2a641=
d9cc516

commit b0c14eae10609f7d688b31d112de2a641d9cc516
Author:     J=C3=A9r=C3=A9mie Jourdin <[email protected]>
AuthorDate: 2026-07-19 18:49:12 +0000
Commit:     Adrian Chadd <[email protected]>
CommitDate: 2026-07-19 18:49:14 +0000

    re(4): add hw.re.aspm_disable loader tunable

    re(4) has unconditionally disabled ASPM L0s/L1 and CLKREQ at attach
    for years; on laptops this costs 200mW+ (requested by adrian@ in the PR=
).

    Make it a tunable following the existing hw.re.* pattern:

    * default 1 keeps today's behavior;
    * 0 preserves the firmware-configured ASPM state at attach and
      skips the watchdog re-assert from the previous revision.

    Documented in re.4.

    * Verified on RTL8168H (XID 0x541): with hw.re.aspm_disable=3D0,
      attach no longer logs "ASPM disabled" and pciconf -lcb shows
      the firmware Link Control state preserved -- including Clock PM,
      which the unconditional code previously cleared.

    * Default (1) is behaviorally identical to the current driver.

    * Note the tunable also stops the driver clearing CLKREQ, a small power
      win even where firmware leaves L0s/L1 off.

    Reviewed by:    adrian
    Differential Revision:  https://reviews.freebsd.org/D58280
    PR: kern/166724

 share/man/man4/re.4 | 11 ++++++++++-
 sys/dev/re/if_re.c  | 17 +++++++++++++----
 2 files changed, 23 insertions(+), 5 deletions(-)

--=20
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.=