[Bug 297455] Mk/Uses/npm.mk: typo "!defied" breaks the documented default (no stage argument)

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=297455

            Bug ID: 297455
           Summary: Mk/Uses/npm.mk: typo "!defied" breaks the documented
                    default (no stage argument)
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: [email protected]
          Reporter: [email protected]

Created attachment 273659
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=273659&action=edit
Mk/Uses/npm.mk: !defied -> !defined

Mk/Uses/npm.mk line 97 reads:

    .  if !defined(_NPM_FETCH_DEP) && !defied(_NPM_EXTRACT_DEP) && \

"!defied" should be "!defined".

That branch is the documented default path.  The file's own usage block says:

    NOTE: If the port specifies none of fetch, extract, build, run or test, we
    assume the port requires build and test dependencies.

so a port written as "USES=npm:npm" — with no stage argument, exactly as the
documentation describes — takes a conditional that does not evaluate as
intended.

Patch attached against Mk/Uses/npm.mk; it is a one-word change.

I found this while preparing sysutils/sysmanage (bug 297372), which as far as I
can tell is the first port in the tree to use USES=npm — "grep -rlE
'USES.*npm:'
/usr/ports/*/*/Makefile" returns nothing here, which may be why this has gone
unnoticed.  My port works around it by always passing an explicit stage
argument (USES=npm:npm,build), so this is not blocking me; I am reporting it so
the next person to follow the documentation does not lose time on it.

Verified still present in ports at commit 0c6c9c01b.

-- 
You are receiving this mail because:
You are the assignee for the bug.