Re: RFD/CFT: www/angie: use upstream versions for all modules; using intermediate variables for DISTVERSION/PORTREVISION?
Gleb Popov <[email protected]>
| Newsgroups | gmane.os.freebsd.devel.ports |
|---|---|
| Message-ID | <CALH631kmOCbbpmeOFO3rkcSKp-MYRj2w-=E1KYuXA3LV5R3xjQ@mail.gmail.com> |
On Fri, Oct 17, 2025 at 3:49 PM Sebastian Oswald <[email protected]> wrote: > > Hello Gleb, > > > I don't get it, why not use ?= when setting PORTREVISION in the master port? > > This is a common technique to allow slaves to override master port's variables. > > > > Thanks for that suggestion. I hope I haven't misunderstood you, but the > problem is not that I want to ovverride PORTREVISION in the master port > - the problem is that if PORTREVISION is set in a slave port, it > propagates to the version of the master port (angie) for the build > process of that slave port. > E.g. setting PORTREVISION=1 for a www/angie-module-* port results in a > dependency to 'angie-<version>_1' which of course does not exist. > I'd have to set the PORTREVISION in the master port (too), which > triggers an unnecessary rebuild of *all* modules and also bumps their > portrevision even if there were zero changes. Ah, that's because of pretty uncommon dependency line RUN_DEPENDS+= angie==${PKGVERSION}:www/angie Why does it have to be "==" ? It seems that slave ports draw the version from the master port anyways, so they won't go out of sync.