Re: node24 compile issue

Alexander Leidinger <[email protected]> Fri, 17 Apr 2026 11:38:53 +0200

Newsgroups	gmane.os.freebsd.devel.ports
Organization	No organization, this is a private message.
Message-ID	<[email protected]>

Am 2026-04-17 09:20, schrieb Alexander Leidinger:
> Am 2026-04-16 17:53, schrieb Shawn Webb:
>> On Thu, Apr 16, 2026 at 12:42:59PM +0200, Alexander Leidinger wrote:
>>> Hi,
>>> 
>>> a build of node24 in poudriere on -current gives me:
>>> ---snip---
>>> ld-elf.so.1: /usr/local/lib/libhdr_histogram.so.6: Undefined symbol
>>> "betoh32"
>>> gmake[1]: *** [libnode.target.mk:13: 
>>> /wrkdirs/usr/ports/www/node24/work/node-v24.14.1/out/Release/obj/gen/node_javascript.cc]
>>> Error 1
>>> ---snip---
>>> 
>>> I have this since a while.
>>> 
>>> I have deleted the the hdr_histogram package from the poudriere pkg
>>> directory to have it rebuild, in case there was an issue there. Same 
>>> result.
>>> 
>>> Any ideas?
>> 
>> The issue stems from the addition of graphics/hdr_histogram as a
>> dependency for node24 and node25. hdr_histogram has quite a few
>> issues, including unaddressed security issues. I glanced at the code
>> and came out more confused than before.
>> 
>> https://github.com/HdrHistogram/HdrHistogram_c/issues
>> 
>> Yesterday, I filed a bug report for HardenedBSD users. I've just noted
>> that FreeBSD is impacted, too:
>> https://github.com/HdrHistogram/HdrHistogram_c/issues/131
> 
> I added an untested suggestion to the ticket.

And attached a patch for HdrHistogramm (also attached to the ticket) 
which results in node24 building since more than 1h instead of failing 
after 50 sec.

Bye,
Alexander.

-- 
http://www.Leidinger.net [email protected]: PGP 0x8F31830F9F2772BF
http://www.FreeBSD.org    [email protected]  : PGP 0x8F31830F9F2772BF

patch-src_hdr__endian.h.patch (text/x-diff, 424 B)

--- src/hdr_endian.h.orig	2026-04-17 07:52:38 UTC
+++ src/hdr_endian.h
@@ -48,14 +48,20 @@
 
 #	include <sys/endian.h>
 
+#ifndef	be16toh
 #	define be16toh(x) betoh16(x)
 #	define le16toh(x) letoh16(x)
+#endif
 
+#ifndef be32toh
 #	define be32toh(x) betoh32(x)
 #	define le32toh(x) letoh32(x)
+#endif
 
+#ifndef	be64toh
 #	define be64toh(x) betoh64(x)
 #	define le64toh(x) letoh64(x)
+#endif
 
 #elif defined(__WINDOWS__)

patch-src_hdr__time.c.patch (text/x-diff, 355 B)

--- src/hdr_time.c.orig	2026-04-17 07:52:30 UTC
+++ src/hdr_time.c
@@ -62,7 +62,7 @@ void hdr_getnow(hdr_timespec* ts)
     hdr_gettime(ts);
 }
 
-#elif defined(__linux__) || defined(__CYGWIN__) || defined(__OpenBSD__)
+#elif defined(__linux__) || defined(__CYGWIN__) || defined(__OpenBSD__) || defined(__FreeBSD__)
 
 
 void hdr_gettime(hdr_timespec* t)

signature.asc (application/pgp-signature, 833 B)