Re: Review requested for piano tuning software

Den 2026-06-26 kl. 21:02, skrev Piotr Smyrak:
> On Fri, 26 Jun 2026 20:35:43 +0200
> Roger Olofsson <[email protected]> wrote:
>
>> A few months ago I made an attempt to create a port for a software
>> that can help with tuning a piano.
>>
>> I would be glad for feedback and review.
>>
>> Bugzilla link
>> <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=293877>
> You are using a hardcoded /usr/local path in the .desktop file. That
> shall rather be $PREFIX, which might change on sysop discretion.
>
> Same remark regarging this patch:
> files/patch-modules_core_calculation_calculationmanager.cpp
>
Hi Piotr,

Thanks for your feedback, I appreciate it!

I am guessing that sysops wants to do "make PREFIX=/path"?

1. For the files/patch-modules_core_calculation_caclulationmanager.cpp 
the hardcoding affects the ${STAGEDIR}, ie the files being built lands 
in ${STAGEDIR} and then the do-install: part of the Makefile takes 
${PREFIX} into consideration.  This should be fine?

2. I have removed the patch file for the .desktop file and done a 
${REINPLACE_CMD} to change the contents of the .desktop file while in 
${STAGEDIR} so this also now takes ${PREFIX} into consideration.

The test mentioned in the porters handbook that says to check make 
clean; make package PREFIX=/var/tmp/'make -V PORTNAME' fails and says it 
can find /lib/qt6/bin/qmake in the /var/tmp path. I suspect the qmake 
comes from USES= qmake. I don't know how to workaround this right now.

The Bugzilla PR is updated with a new git format-patch origin/main.

Roger