[Bug 233693] [PowerPC64] Powerd unable to change cpu frequency

[email protected]
Newsgroups gmane.os.freebsd.devel.ppc
Message-ID <[email protected]/bugzilla/>
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233693

Conrad Meyer <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[email protected]            |[email protected]
                 CC|                            |[email protected]

--- Comment #2 from Conrad Meyer <[email protected]> ---
It doesn't fix this issue, but I suspect there is an off-by-one bug in
pmcr_set():

--- a/sys/powerpc/cpufreq/pmcr.c
+++ b/sys/powerpc/cpufreq/pmcr.c
@@ -189,7 +190,7 @@ pmcr_set(device_t dev, const struct cf_setting *set)
        if (set == NULL)
                return (EINVAL);

-       if (set->spec[0] < 0 || set->spec[0] > npstates)
+       if (set->spec[0] < 0 || set->spec[0] >= npstates)
                return (EINVAL);

        pmcr = ((long)pstate_ids[set->spec[0]] << PMCR_LOWERPS_SHIFT) &

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ppc
To unsubscribe, send any mail to "[email protected]"
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.