Re: bin/93853: [PATCH]: Add country-specific keymap selection to sysinstall

On Tue, Feb 28, 2006 at 02:19:52PM -0500, John Baldwin wrote:
> Hmm, I tried this out.  One thing I ran into just running it during multiuser
> is that hitting Enter didn't work in the country selection dialog.  I had to
> hit 'O' for Ok for some reason.  It works if I pick a non-default country
> actually, so it's something in the logic for the default country case.  Hmm,
> I fixed this by fixing dmenuSetCountryVariable() to return DITEM_SUCCESS
> rather than void in the DEFAULT_COUNTRY case.  That's really odd that it
> didn't flag that as a warning.  Also, I fixed keymapMenuSelect() to correctly
> return a DITEM_* value if VAR_COUNTRY wasn't set (dmenuOpenSimple returns a
> boolean).  Finally, I think that this should only popup during installs and
> if it is run as non-init it shouldn't pop this menu up (under the assumption
> that in multiuser you've already set the keymap).

Yeah, everything you've changed looks good.  It occured to me last night as I
was using sysinstall to label a disk that it would be irritating for the
country menu to come up post-install.

Raising the WARNS to 2 shows that I also missed a restorescr(w) at the end of
configCountry(), and there are some orphaned functions sprinkled about.

-- 
Seth Kingsley || [email protected]

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (FreeBSD)

iD8DBQFEBK5fD1AymFxBOwgRAjldAJ9XkQ69Hu+O3k3/7jC5RuQqZYuTrACeMpFu
XhtECICThPOCMtAyZaLO8dI=
=Tcof
-----END PGP SIGNATURE-----