[Bug 270852] Extra characters in config files after upgrade

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270852

            Bug ID: 270852
           Summary: Extra characters in config files after upgrade
           Product: Base System
           Version: 13.2-RELEASE
          Hardware: amd64
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: standards
          Assignee: [email protected]
          Reporter: [email protected]

Hi,

This has been a major issuse for sometime. After any release updates, such as
last one I have done recently, after issueing :
freebsd-update -r 13.2-RELEASE upgrade          (from 13.1)
..
At the step The following file could not be merged automatically: /etc/passwd
Press Enter to edit this file in /usr/bin/vi and resolve the conflicts
manually...


I get the following post (my default editor is vi)

..
<<<<<<< current version
# $FreeBSD$
#
root:*:0:0:Charlie &:/root:/usr/local/bin/bash
=======
root:*:0:0:Charlie &:/root:/bin/csh
toor:*:0:0:Bourne-again Superuser:/root:
>>>>>>> 13.2-RELEASE
..

Major inconsistencies and critical defects:

It is an upgrade, should not change passwd file in any way, unless standart /
delimiter / format changed. If user don't pay attention and save it the way it
is then passwd file becomes corrupted.

I understand the intent is somewhat adding patch phrase, however,
a) it is not the job of upgrade script to change my passwd file.
b) It is not the job of upgrade script adding already removed user(s) like
'toor', back.


SUPER CRITICAL:

Upgrade script patches sshd server system-wide configuration file. It is too
crowded already and hard to see/catch patches on screen.
If I don't pay enough attention and save it the way it is, it continues with
invalid characters inserted into sshd_config.

Auto inserted lines similar to the followings are absolute SSHD/PAM killer.

@@ -56,10 +55,11 @@
@@ -77,11 +77,11 @@
<<<<<<< current version
>>>>>>>

...


This once made sshd_config file invalid and, after reboot, SSHD did not start
and I was not able to access server remotely. Almost cost me my job.

Please stop this type of standarts in upgrades. Simply dangerous. More harm
than good.

Instead, create a large files of:
1) what's done/applied, call it UPGRADE-timestamp.upgrade
2) what needs to be confirmed by user, call it PENDING-timestamp.upgrade
Let user review and apply further changes.

Thanks,.

-- 
You are receiving this mail because:
You are the assignee for the bug.