[Bug 294719] lib/msun: Added fmaximum_mag_num

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D294719

--- Comment #7 from Steve Kargl <[email protected]> ---
(In reply to Robert Clausecker from comment #4)
I don't know the internals for libm's signbit().  Naively,
I would have thought that both gcc and clang provide=20
__builtin_signbit() with optimal implementations if
one uses signbit().  I would follow the 'make it
work, make it correct, and then make it fast' maxim.

I haven't figured out what Jesus is trying to do
with the force_except.  Reading the description of
fmaximum_num etc, I would try something like

if (nan_x) {
   if (nan_y)
      return (x + y);

   if (issignaling(x))
      feraiseexcept(FE_INVALID);

   return (y);
}

if (nan_y) {

   if (issignaling(y))
      feraiseexcept(FE_INVALID);

   return (x);
}

--=20
You are receiving this mail because:
You are the assignee for the bug.=