[Bug 270661] taskqgroup_cpu_create does taskqueue_thread_enqueue not gtaskqueue_thread_enqueue
[email protected] Sun, 31 Dec 2023 16:49:56 +0000
| Newsgroups | gmane.os.freebsd.devel.threading |
|---|---|
| Message-ID | <[email protected]/bugzilla/> |
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270661 --- Comment #2 from [email protected] --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=e1f336704d308679d4178fd5063dba854b22a07b commit e1f336704d308679d4178fd5063dba854b22a07b Author: Mark Johnston <[email protected]> AuthorDate: 2023-12-31 16:36:12 +0000 Commit: Mark Johnston <[email protected]> CommitDate: 2023-12-31 16:49:08 +0000 gtaskqueue: Fix a typo This is a no-op in practice since gtaskqueue_thread_enqueue() and taskqueue_thread_enqueue() are identical, and while _gtaskqueue_create() compares the enqueue callback pointer with gtaskqueue_thread_enqueue(), the result has no effect since TQ_FLAGS_UNLOCKED_ENQUEUE was copied directly from subr_taskqueue.c and is unused in the gtaskqueue code. Fix it anyway since it's a bug. More generally we really need to consolidate subr_taskqueue.c and subr_gtaskqueue.c. PR: 270661 MFC after: 1 week sys/kern/subr_gtaskqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- You are receiving this mail because: You are the assignee for the bug.