maintainer-feedback requested: [Bug 257264] graphics/drm-fbsd13-kmod fails to build after LinuxKPI update

Bugzilla Automation <[email protected]> has asked freebsd-x11 (Nobody)
<[email protected]> for maintainer-feedback:
Bug 257264: graphics/drm-fbsd13-kmod fails to build after LinuxKPI update
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257264



--- Description ---
Since the commits on 17-Jul to update the linuxkpi to support iwlwifi and other
issues, drm-fbsd13-kmod will no longer build. make buildworld also fails while
building the kernel module, as well with the same issues with strings.

From UPDATING:
20210718:
	Bump __FreeBSD_version to 1300512 after merging LinuxKPI, OFED,
	net80211, and driver changes in order to support building
	Intel wireless iwlwifi drivers.  This is especially needed for
	drm-kmod which needs updates after this.

It reads like this was committed with knowledge that it would likely break
buildkernel on STABLE. Huh! I hope I'm misreading this as STABLE should not get
updates which are known will break the kernel for may users. 

Error from log:
cc  -O2 -pipe -fno-strict-aliasing '-DKBUILD_MODNAME="linuxkpi_gplv2"'
-DLINUXKPI_VERSION=50000 -DCONFIG_DRM_AMDGPU_CIK -DCONFIG_DRM_AMDGPU_SI
-DCONFIG_DRM_AMD_DC -DCONFIG_DRM_AMD_DC_FBC -DCONFIG_DRM_AMD_POWERPLAY
-DCONFIG_DRM_I915_ALPHA_SUPPORT -DCONFIG_DRM_I915_FORCE_PROBE='"*"'
-DCONFIG_DRM_I915_CAPTURE_ERROR -DCONFIG_DRM_I915_SPIN_REQUEST=5
-DCONFIG_DRM_I915_USERFAULT_AUTOSUSPEND=250 -DCONFIG_DRM_LOAD_EDID_FIRMWARE
-DCONFIG_DRM_MIPI_DSI -DCONFIG_DRM_PANEL_ORIENTATION_QUIRKS
-DCONFIG_DRM_VMWGFX_FBCON -DCONFIG_DRM_FBDEV_EMULATION
-DCONFIG_DRM_FBDEV_OVERALLOC=100 -DCONFIG_DRM_LEGACY -DCONFIG_DRM_VM
-DCONFIG_ARCH_HAVE_NMI_SAFE_CMPXCHG -DCONFIG_BACKLIGHT_CLASS_DEVICE
-DCONFIG_DMI -DCONFIG_FB -DCONFIG_MTRR -DCONFIG_PCI -DCONFIG_PM -DCONFIG_SMP
-DCONFIG_ACPI -DCONFIG_ACPI_SLEEP -DCONFIG_AGP -DCONFIG_X86 -DCONFIG_X86_PAT
-DCONFIG_64BIT -DCONFIG_AS_MOVNTDQA -DCONFIG_COMPAT -DCONFIG_X64_64
-DCONFIG_DRM_AMD_DC_DCN1_0 -DCONFIG_DRM_AMD_DC_DCN1_01
-DCONFIG_DRM_AMD_DC_DCN2_0 -DCONFIG_DRM_AMD_DC_DSC_SUPPORT  -Werror -D_KERNEL
-DKLD_MODULE -nostdinc 
-I/usr/ports/graphics/drm-fbsd13-kmod/work/drm-kmod-drm_v5.4.92_3/include
-I/usr/ports/graphics/drm-fbsd13-kmod/work/drm-kmod-drm_v5.4.92_3/linuxkpi/dumm
y/include
-I/usr/ports/graphics/drm-fbsd13-kmod/work/drm-kmod-drm_v5.4.92_3/linuxkpi/gplv
2/include
-I/usr/src/sys/compat/linuxkpi/common/include -include
/usr/ports/graphics/drm-fbsd13-kmod/work/drm-kmod-drm_v5.4.92_3/obj/usr/ports/g
raphics/drm-fbsd13-kmod/work/drm-kmod-drm_v5.4.92_3/linuxkpi/opt_global.h
-I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common 
-fno-omit-frame-pointer -mno-omit-leaf-frame-pointer
-fdebug-prefix-map=./machine=/usr/src/sys/amd64/include
-fdebug-prefix-map=./x86=/usr/src/sys/x86/include     -MD 
-MF.depend.linux_compat.o -MTlinux_compat.o -mcmodel=kernel -mno-red-zone
-mno-mmx -mno-sse -msoft-float	-fno-asynchronous-unwind-tables -ffreestanding
-fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs
-Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef
-Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs
-fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error=tautological-compare
-Wno-error=empty-body -Wno-error=parentheses-equality
-Wno-error=unused-function -Wno-error=pointer-sign
-Wno-error=shift-negative-value -Wno-address-of-packed-member
-Wno-format-zero-length -Wno-pointer-arith   -mno-aes -mno-avx 
-std=iso9899:1999 -c
/usr/ports/graphics/drm-fbsd13-kmod/work/drm-kmod-drm_v5.4.92_3/linuxkpi/gplv2/
src/linux_compat.c
-o linux_compat.o
In file included from
/usr/ports/graphics/drm-fbsd13-kmod/work/drm-kmod-drm_v5.4.92_3/linuxkpi/gplv2/
src/linux_compat.c:10:
In file included from
/usr/ports/graphics/drm-fbsd13-kmod/work/drm-kmod-drm_v5.4.92_3/linuxkpi/gplv2/
include/linux/pci.h:10:
In file included from
/usr/src/sys/compat/linuxkpi/common/include/linux/pci.h:55:
In file included from
/usr/src/sys/compat/linuxkpi/common/include/linux/dmapool.h:37:
In file included from
/usr/ports/graphics/drm-fbsd13-kmod/work/drm-kmod-drm_v5.4.92_3/linuxkpi/gplv2/
include/linux/device.h:4:
In file included from
/usr/src/sys/compat/linuxkpi/common/include/linux/device.h:36:
In file included from
/usr/ports/graphics/drm-fbsd13-kmod/work/drm-kmod-drm_v5.4.92_3/linuxkpi/gplv2/
include/linux/kobject.h:4:
In file included from
/usr/src/sys/compat/linuxkpi/common/include/linux/kobject.h:37:
/usr/src/sys/compat/linuxkpi/common/include/linux/kref.h:118:2: error: implicit
declaration of function '__stringify' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
	WARN_ON(release == NULL);
	^
/usr/src/sys/compat/linuxkpi/common/include/linux/kernel.h:128:7: note:
expanded from macro 'WARN_ON'
		    __stringify(cond), __FILE__, __LINE__);	\
		    ^
In file included from
/usr/ports/graphics/drm-fbsd13-kmod/work/drm-kmod-drm_v5.4.92_3/linuxkpi/gplv2/
src/linux_compat.c:10:
In file included from
/usr/ports/graphics/drm-fbsd13-kmod/work/drm-kmod-drm_v5.4.92_3/linuxkpi/gplv2/
include/linux/pci.h:10:
In file included from
/usr/src/sys/compat/linuxkpi/common/include/linux/pci.h:55:
In file included from
/usr/src/sys/compat/linuxkpi/common/include/linux/dmapool.h:37:
In file included from
/usr/ports/graphics/drm-fbsd13-kmod/work/drm-kmod-drm_v5.4.92_3/linuxkpi/gplv2/
include/linux/device.h:4:
In file included from
/usr/src/sys/compat/linuxkpi/common/include/linux/device.h:36:
In file included from
/usr/ports/graphics/drm-fbsd13-kmod/work/drm-kmod-drm_v5.4.92_3/linuxkpi/gplv2/
include/linux/kobject.h:4:
In file included from
/usr/src/sys/compat/linuxkpi/common/include/linux/kobject.h:37:
/usr/src/sys/compat/linuxkpi/common/include/linux/kref.h:118:2: error: format
specifies type 'char *' but the argument has type 'int' [-Werror,-Wformat]
	WARN_ON(release == NULL);
	^~~~~~~~~~~~~~~~~~~~~~~~
/usr/src/sys/compat/linuxkpi/common/include/linux/kernel.h:128:7: note:
expanded from macro 'WARN_ON'
		    __stringify(cond), __FILE__, __LINE__);	\
		    ^~~~~~~~~~~~~~~~~
2 errors generated.
*** Error code 1

Stop.
make[3]: stopped in
/usr/ports/graphics/drm-fbsd13-kmod/work/drm-kmod-drm_v5.4.92_3/linuxkpi
*** Error code 1

Stop.
make[2]: stopped in
/usr/ports/graphics/drm-fbsd13-kmod/work/drm-kmod-drm_v5.4.92_3
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/graphics/drm-fbsd13-kmod
*** Error code 1

Stop.
make: stopped in /usr/ports/graphics/drm-fbsd13-kmod