maintainer-feedback requested: [Bug 261654] x11/libinput: enabling DEBUG_GUI fails to build

Bugzilla Automation <[email protected]> has asked freebsd-x11 (Nobody)
<[email protected]> for maintainer-feedback:
Bug 261654: x11/libinput: enabling DEBUG_GUI fails to build
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261654



--- Description ---
Enabling DEBUG_GUI option in x11/libinput fails to build.
Requiring wayland and wayland-protocols as the attached patch makes it build,
but I am not sure if it is the right solution.

1) libinput-debug-gui.c
 
https://gitlab.freedesktop.org/libinput/libinput/-/blob/e9ccd4f402a8b56590acc83
009f4045b145587bf/tools/libinput-debug-gui.c
  includes "pointer-constraints-unstable-v1-client-protocol.h" when
GDK_WINDOWING_WAYLAND is defined.
2) GDK_WINDOWING_WAYLAND is defined in
/usr/local/include/gtk-3.0/gdk/gdkconfig.h without any condition.
  I did not verify but is it because I enabled WAYLAND in x11-toolkits/gtk30?
3) libinput's meson.build
 
https://gitlab.freedesktop.org/libinput/libinput/-/blob/e9ccd4f402a8b56590acc83
009f4045b145587bf/meson.build
  only provides "pointer-constraints-unstable-v1-client-protocol.h" when
wayland-client and wayland-protocols are found.

What I am not sure is: is GDK_WINDOWING_WAYLAND in gdkconfig.h is always
defined? Isn't it defined only when option WAYLAND is enabled in
x11-toolkits/gtk30? Then how do I detect it in x11/libinput's port Makefile?

The log is as follows:

cc -Ilibinput-debug-gui.p -I. -I.. -I../src -I../include
-I/usr/local/include/libepoll-shim -I/usr/local/include/gtk-3.0
-I/usr/local/include/pango-1.0 -I/usr/local/include
-I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include
-I/usr/local/include/harfbuzz -I/usr/local/include/freetype2
-I/usr/local/include/libpng16 -I/usr/local/include/fribidi
-I/usr/local/include/cairo -I/usr/local/include/pixman-1
-I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/gio-unix-2.0
-I/usr/local/include/atk-1.0 -I/usr/local/include/at-spi2-atk/2.0
-I/usr/local/include/dbus-1.0 -I/usr/local/lib/dbus-1.0/include
-I/usr/local/include/at-spi-2.0 -I/usr/local/include/libevdev-1.0
-I/usr/local/include/libwacom-1.0 -I/usr/local/include/gudev-1.0
-fno-color-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra
-std=gnu99 -O3 -Wno-unused-parameter -Wmissing-prototypes -Wstrict-prototypes
-Wundef -Wpointer-arith -Wuninitialized -Winit-self -Wstrict-prototypes
-Wimplicit-fallthrough -Wredundant-decls -Wincompatible-pointer-types
-Wformat=2 -Wno-missing-field-initializers -Wmissing-declarations
-fvisibility=hidden -O2 -pipe -fstack-protector-strong -isystem
/usr/local/include -fno-strict-aliasing -isystem /usr/local/include -pthread
-D_THREAD_SAFE -MD -MQ libinput-debug-gui.p/tools_libinput-debug-gui.c.o -MF
libinput-debug-gui.p/tools_libinput-debug-gui.c.o.d -o
libinput-debug-gui.p/tools_libinput-debug-gui.c.o -c
../tools/libinput-debug-gui.c
../tools/libinput-debug-gui.c:53:11: fatal error:
'pointer-constraints-unstable-v1-client-protocol.h' file not found
	#include "pointer-constraints-unstable-v1-client-protocol.h"
		 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.