[Bug 276492] [NEW PORT] editors/sciteco: Scintilla-based Text Editor and Corrector

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276492

Rodrigo Osorio <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Open                        |In Progress

--- Comment #9 from Rodrigo Osorio <[email protected]> ---
Hi,

I did a review of your patch and I have a few remarks:
  * the gtk flavor doesn't work due to the fact you try
    to execute a non executable script.
  * ${SCRIPTSDIR}/xvfb-run.sh has to be moved to ${FILESDIR}/xvfb-run.sh.in
    and moved to the ${WRKDIR} diring pre-build
  * MAKE_CMD=${SH} ${WRKDIR}/xvfb-run.sh ${GMAKE}
  * Don't hesitate to use portclipy and portfmt to properly format your
makefile


For now I didn't try all the options :p

I attach a patch with my suggestion of improvements.

All the best
-- rodrigo

-- 
You are receiving this mail because:
You are on the CC list for the bug.