re: ANNOUNCE FDIinstall preview -> further ideas

On Mon, 21 Oct 2002, Eric Auer wrote:

I'll answer this first:

>
> Now some feedback on the current FDINSTALL implementation:
> When in doubt, use IF to ensure the existence of the PREFIX and LOGDIR
> directories and the PACKAGE itself...

Good point.

> Hm. A prefix allways causes simulate? Or do I misread here?

Not entierly sure what part of the file you are referring to but I'll walk
you through the first part:

if '%2'=='/simulateonly' set SIMULATE=-t
This should be obvious if the second arg is /simulateonly, then we assume
that no prefix was given.

if '%3'=='/simulateonly' goto prefix
if the third arg was /simulateonly ,then the second is assumed to be the

:prefix
if NOT '%2'=='' set PREFIX=%2

an unnesessary safety check. ;)

> You do not use %UNZIP% so you need not un-set it :-).

Ah. yes. it is a reminder, I did use it in an early version, but changed
my mind, and then I forgot to remove the unsetting.

> Now about uninstal.bat:
> Hm. Shouldnt you popd before you RM ...@...?

nope, because the paths in the logfile aren't absolute, so I'll cd to the
prefix dir and then remove stuff from teher, and then cd back.

> And if rm gives an
> errorlevel, you should probably avoid deleting the logfiles if rm
> signals failure.

Good point. I'll Implement it next. Currently rm allways returns 0.

>
> Thanks for your efforts so far, I am curious to see the next version.
>

Thank you for the feedback.

--Wolf

-- 

  |\ _		Maintainer of DOG - The New Shell!
  |  .\---.	http://dog.sourceforge.net/index.php
 /  ,____/	http://sourceforge.net/projects/dog
/   /C:\DOG\>_	[email protected]

Humpty Dumpty sat on a wall
Humpty Dumpty had a great fall
All the king's horses and all the king's men
Couldn't put Humpty together again.