Re: [PATCH gnumach] tests/user-qemu.mk: Add missing include for string.h and sys headers

Hello,

Damien Zammit, le dim. 21 juin 2026 00:45:59 +0000, a ecrit:
> On 20/6/26 11:53 pm, Samuel Thibault wrote:
> 
>     Damien Zammit, le sam. 20 juin 2026 02:11:04 +0000, a ecrit:
> 
>         This change allows cross compilation of the test suite from a
>         non-x86 GNU/Linux host.
> 
>     What does this actually fix?
> 
>     $(MACH_TESTINSTALL) already integrates the headers that gnumach
>     installs. What more do tests need that aren't available that way?
> 
> Apologies, the missing headers are <string.h> and <sys/types.h>
> according to my build log.
> 
> Maybe my configuration of the tests build is missing an include path?

No. These are indeed an odd case:

- they are proper userland headers
- but we are not supposed to install them since we are not libc
- but we indeed provide string functions for the small "libc" (see
  strings.c in $(SRC_TESTLIB))

I have now added symlinks for these in tests/include

Samuel