Re: [PATCH 2/4 gnumach] cons: Print to hypervisor console for debugging

On July 4, 2026 4:58:48 AM GMT+01:00, Damien Zammit <[email protected]>
wrote:
>We should not disable this option behind an "if 0" because
>xen platform enabled gnumach needs to print somewhere for unit tests.
>Seeing a blank screen is too confusing and unnecessary when there is an
>emergency console available.
>---
> device/cons.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/device/cons.c b/device/cons.c
>index 3f7cb9d1..e1bc1ae0 100644
>--- a/device/cons.c
>+++ b/device/cons.c
>@@ -27,6 +27,10 @@
> #include <mach/boolean.h>
> #include <device/cons.h>
> 
>+#ifdef MACH_HYP
>+#include <xen/console.h>
>+#endif
>+
> #ifdef MACH_KMSG
> #include <device/io_req.h>
> #include <device/kmsg.h>
>@@ -150,7 +154,7 @@ cnputc(char c)
> 	kmsg_putchar (c);
> #endif
> 	
>-#if defined(MACH_HYP) && 0
>+#if defined(MACH_HYP)
> 	{
> 		/* Also output on hypervisor's emergency console, for
> 		 * debugging */
>
LGTM, no issues.
Thanks!