Re: [PATCH] Source code files for sound library

On Thu, 13 Aug 2026, 01:35 Diego Nieto Cid, <[email protected]> wrote:

> Hi,
>
> On Thu, Aug 13, 2026 at 03:41:31AM +0300, Ahemd Khider wrote:
> > From: astra <[email protected]>
>
> I'm not sure about the authorship policy, but you probably need a name and
> a valid email.
>
>
> I forgot to edit this , the files contain my name and my email address , I
will edit it next time :)

>
> >
> > ---
> >  libsound/audio.c  |  64 ++++++++++++++++++++++++++
> >  libsound/audio.h  | 111 ++++++++++++++++++++++++++++++++++++++++++++++
> >  libsound/makefile |   7 +++
>
> To be applied where?
>
>
> As far as I know there are'nt any audio directary so we should create one?

>
> > +bool init_hda_enge(volatile uint32_t *cntlr);
>
> Weird signature. :P
>
It should be void right ? , i put it as an boolean so when the controller
failed to initialize it will return an failure

> > +
> > +#endif /* HURD_AUDIO_INTERFACE */
> > diff --git a/libsound/makefile b/libsound/makefile
> > new file mode 100644
> > index 00000000..ee5046e5
> > --- /dev/null
> > +++ b/libsound/makefile
> > @@ -0,0 +1,7 @@
> > +CC ?= gcc
> > +CFLAGS = -Wall -Wextra
> > +
> > +haudis: audio.o
>
> Shouldn't this call the linker?
>
>
> > +
> > +audio.o:
> > +     $(CC) -o audio.c
>
> Missing -o argument?
>
> I forgot to edit it after remove the test executable :/

 , I will edit it in future

>
>
>
> --
> cheers!
>
Any time :)

>