Re: [PATCH] Source code files for sound library
Ahmed Khider <[email protected]>
| Newsgroups | gmane.os.hurd.bugs |
|---|---|
| Message-ID | <CADy5EEZKFJKy92A6hKYJkJ6yjKDQv6z0G43fyuGMeD+YudOGTg@mail.gmail.com> |
Hello Sorry for the chaos I didnt the past message well :) the code look like an ai generated because a lot of comment between the lines I was trying to made it a self documented and the registers are all commented because it hard to remmber what the register do by the shortcut I used osdev audio articles for HDA¹ and AC97² as reference to me because the intel specifications manual wasnt clear enough to me :/ 1-https://wiki.osdev.org/Intel_High_Definition_Audio 2-https://wiki.osdev.org/AC97 with best wishes Ahmed On Thu, 13 Aug 2026, 07:37 Bradley Morgan, <[email protected]> wrote: > On 13 August 2026 02:20:22 BST, Ahemd Khider <[email protected]> wrote: > >--- > > NAK, just putting patches on top of patches atp. > > > I was suggesting: > > > /* Authored by: Ahmed Khider <[email protected]> */ > > > or something, hard NAK to this slop > > > > libsound/audio.c | 5 +++-- > > libsound/audio.h | 7 +++++-- > > libsound/makefile | 2 +- > > 3 files changed, 9 insertions(+), 5 deletions(-) > > > >diff --git a/libsound/audio.c b/libsound/audio.c > >index 7d18e41f..b67f45ea 100644 > >--- a/libsound/audio.c > >+++ b/libsound/audio.c > >@@ -1,7 +1,8 @@ > > /* This File Is Part Of Hurd Audio Interface System (Haudis) */ > >-/* This file Is Under GNU General Public License Version 3 (GPL3) */ > >+/* This File Is Under GNU General Public License Version 3 (GPL3) */ > > /* Original Author : AHMED KHIDER (2026) */ > >- > >+/* Email : [email protected] */ > >+/* File Describe : Translation Unit For Haudis Core Library */ > > > > > > #include "audio.h" > >diff --git a/libsound/audio.h b/libsound/audio.h > >index 2b07c902..1a3a5bac 100644 > >--- a/libsound/audio.h > >+++ b/libsound/audio.h > >@@ -1,6 +1,9 @@ > > /* This File Is Part Of Hurd Audio Interface System (Haudis) */ > > /* This file Is Under GNU General Public License Version 3 (GPL3) */ > > /* Original Author : AHMED KHIDER (2026) */ > >+/* Email : [email protected] */ > >+/* File Describe : Core Library For Haudis */ > >+ > > > > #ifndef HURD_AUDIO_INTERFACE > > #define HURD_AUDIO_INTERFACE > >@@ -15,7 +18,7 @@ > > #define HDA_GCP 0x00 /* Global Capablities */ > > #define HDA_MNV 0x02 /* Minor Version */ > > #define HDA_MJV 0x03 /* Major Version */ > >-#define HDA_GC 0x08 /* Global control */ > >+#define HDA_GC 0x08 /* Global Control */ > > #define HDA_ST 0x0E /* Status Test */ > > #define HDA_IC 0x20 /* Interrupt Control */ > > #define HDA_STREAM_SYNCH 0x34 /* Stream Synchronization */ > >@@ -47,7 +50,7 @@ > > #define HDA_SD_FIFOWM2 0x0F /* Stream FIFO Watermark */ > > #define HDA_SD_FMT1 0x12 /* Stream Format */ > > #define HDA_SD_FMT2 0x13 /* Stream Format */ > >-#endif /* INTEL_HDA_REG*/ > >+#endif /* INTEL_HDA_REG */ > > > > > > /* Intel AC97 Registers */ > >diff --git a/libsound/makefile b/libsound/makefile > >index ee5046e5..d8632e5b 100644 > >--- a/libsound/makefile > >+++ b/libsound/makefile > >@@ -1,5 +1,5 @@ > > CC ?= gcc > >-CFLAGS = -Wall -Wextra > >+CFLAGS ?= -Werror -Wextra > > > > haudis: audio.o > > > > > > Thanks! >