Re: [PATCH v3 1/6 incubator] smb: Update to new api
Samuel Thibault <[email protected]>
| Newsgroups | gmane.os.hurd.bugs |
|---|---|
| Organization | I am not organized |
| Message-ID | <aotpwFXoU1qp2exG@end> |
Damien Zammit, le mer. 12 août 2026 00:57:07 +0000, a ecrit:
> Convert all the legacy api calls to modern ones.
>
> Requires to remove _FILE_OFFSET_BITS and be compatible with samba.
>
> If samba is compiled on a 32b machine, it may only support 32 bit offsets.
Mmm, have you tried building this on a 32b machine? Which version of
libsmbclient-dev were you using? With 2:4.24.6+dfsg-1, I am getting:
/usr/include/samba-4.0/libsmbclient.h:84:13: error: size of array ‘smbc_off_t_should_be_at_least_64bits_use_LFS_CFLAGS’ is too large
84 | typedef int smbc_off_t_should_be_at_least_64bits_use_LFS_CFLAGS[sizeof(off_t)-7];
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Samuel