Re: removing "su" from coreutils [Re: Fwd: [PULL] su
Thomas Schwinge <[email protected]> Tue, 29 May 2012 11:50:25 +0200
| Newsgroups | gmane.os.hurd.devel.readers |
|---|---|
| Message-ID | <87396jb9jy.fsf__32227.4976330393$1338285078$gmane$org@schwinge.name> |
--=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! On Fri, 25 May 2012 11:26:00 +0200, I wrote: > On Thu, 24 May 2012 15:21:01 +0200, Jim Meyering <[email protected]> wrote: > > P=C3=A1draig Brady wrote: > > > -------- Original Message -------- > > > Subject: [PULL] su > > > Date: Thu, 24 May 2012 14:58:01 +0200 > > > From: Ludwig Nussel <[email protected]> > > > To: [email protected] > > > > > > Hi, > > > > > > coreutils isn't really interested in maintaining su anymore. > > > Distributions have to add custom patches to fix bugs and add > > > features. The worst offender is probably the pam patch. Fortunately > > > we managed to sync the patch between openSUSE and Fedora meanwhile. > > > Over time the risk that the patches divert again increases though. > > > Since util-linux now contains a common login program it looks like a > > > good new home for su too. > > > > > > To integrate su into util-linux I've extracted the history of the su > > > program until the last GPLv2 version (they've changed to GPLv3 > > > meanwhile) from coreutils' git and merged it with util-linux. > > > Then I've added the patches used in Fedora and openSUSE and fixed the > > > files to actually build. > > > > > > You can find the result in branch su-v1 (ff6b15d) at > > > [email protected]:lnussel/util-linux.git > > > > > > I've also filed a pull request on github: > > > https://github.com/karelzak/util-linux/pull/10 > > > > > > Originally I had planned to implement separate tty allocation for > > > the child program on top of that to get rid of the evil setsid > > > patch. It turned out to be more complicated than I thought though. The > > > change would be too massive to backport anyways I guess. So the next > > > step would be to rip out the non-pam legacy stuff and clean up the co= de > > > to make it readable again. >=20 > > I would like to remove su.c, if/when possible from coreutils. > > The last time I proposed that, the Hurd was mentioned as a > > reason not to, since they relied on the su from coreutils. > >=20 > > Is that still the case, and if so, can you (the Hurd) switch > > to the one from util-linux? >=20 > Yes, that appears to be fine -- despite its name, we're using a lot of > executables provided by util-linux. >=20 > I'll test the branch in the lnussel repository and report back. A minor portability patch was all that was needed, <http://news.gmane.org/find-root.php?message_id=3D%3C1337971261-20684-1-git= [email protected]%3E>, and all that has now been merged to util-linux. How to coordinate this with Debian? Chances are that an updated coreutils release with su removed is made before an util-linux release with su added. Gr=C3=BC=C3=9Fe, Thomas --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAEBAgAGBQJPxJvhAAoJENuKOtuXzphJM7sH/izAKGq0FdCWkEjbEt9JMSe7 1i9m86Y74Mgg7+tng6yY+79dA+Iszm3qkC/hASPwirL/dooE9wlbZhD3Yux/Df8J g9Cqhm9QGR30T8RdrYj2lPhS1531lhwRtFZqTTPnzYKlbnx5zwOeUO2zfFheZy8g X8WlqCtuV7dzc9fuzDIqz5Q6WlpkVJort7ua3v1CKJDQhl6uSiLMFvRDChWtJe6P ruZZEHTwlGqNYWSe06hryfVP5G07P0AHQsGD+SCpBdmgG64KYJ484+r12kjOsVpx rx+X5JvdXtZmScpgdi1PIEbxoo7KgT3cIVLpb3BRhhLPIy/RKqm2nA1SoPRM5kk= =Swrw -----END PGP SIGNATURE----- --=-=-=--