Re: Trouble executing example translator from Hurd Hacking Guide

Samuel Thibault <[email protected]> Sun, 28 Jul 2019 11:33:13 +0200
Newsgroups gmane.os.hurd.bugs,gmane.os.hurd.general
Organization I am not organized
Message-ID <20190728093313.s5zyy7sfotaybj5l@function>
Hello,

Andrew Eggenberger, le dim. 28 juil. 2019 04:21:21 -0500, a ecrit:
> It's working now,

Good :)

> Both putting #define _FILE_OFFSET_BITS 64 and switching the offset
> type in the read function to loff_t

? Only one of the two should be needed. Note that the #define needs to
be very first, before #includes, since it's driving what includes are
supposed to do.

> There's also a small bug in the program itself. Instead of assigning
> the char '1' in the for loop, it's assigning the int 1, causing it to
> output the character with the ascii code 1.

AIUI that was the purpose, but apparently it would be less surprising to
emit '1' chars, so I changed that too.

Samuel