Re: lib/58282: Sysinst terminal output size increased because curses

On Tue, Jun 30, 2026 at 05:15:01AM +0000, Brett Lymn via gnats wrote:
> The following reply was made to PR lib/58282; it has been noted by GNATS.
> 
> From: Brett Lymn <[email protected]>
> To: Andreas Gustafsson <[email protected]>
> Cc: [email protected]
> Subject: Re: lib/58282: Sysinst terminal output size increased because curses
> Date: Tue, 30 Jun 2026 14:44:44 +0930
> 
>  On Tue, Jun 30, 2026 at 07:31:12AM +0300, Andreas Gustafsson wrote:
>  > 
>  > I don't see the reversion on cvs.netbsd.org yet.
>  >
>  
>  Thanks to kre for sorting this.  I thought I had done it but cvs was
>  complaining about a sticky flag.
>  

OK, I have committed the update again now.  There was a problem in
quickch() that caused it to loop infinitely.  I have cleaned up
quickch() to remove a lot of historical changes that were done as
incidental work arounds for the broken hashes.  I tested sysinst and it
works fine now as does vi.

I am still deeply suspicious of quickch(), I don't believe that it
always does the correct thing as I can see what I consider to be
spurious scrolling regions being set in some of the tests but in other
tests the outputs are well optimised - e.g. the scroll test does the
right thing in setting a scrop region instead of rewriting the whole
screen on a single line scroll.

All atf tests pass with this update now.

-- 
Brett Lymn
--
Sent from my NetBSD device.

"We are were wolves",
"You mean werewolves?",
"No we were wolves, now we are something else entirely",
"Oh"