Re: sysbuild of netbsd-10 from netbsd-10 fails after upgrade of itself

At Thu, 9 Oct 2025 07:39:27 +0000 (UTC), RVP <[email protected]> wrote:
Subject: Re: sysbuild of netbsd-10 from netbsd-10 fails after upgrade of itself
>
> An amd64 tools build completed successfully for me yesterday. Did a i386 tools
> build just now. No issues. Sources and ISOs from:
>
> https://nycdn.netbsd.org/pub/NetBSD-daily/netbsd-10/20251006162410Z/

Hmmm.... very interesting.

This diff is silent:

     diff -r /home/sysbuild/i386/destdir/usr/include /usr/include

So that should prove there's nothing old or corrupt left over in
/usr/include from the 10.0 install -- it was all upgraded properly.

As I showed I can see from the sources I have and the headers that are
in my system the build cannot possibly succeed, yet presumably you have
the same source and installed headers and it works?

Hmmm.... what if I re-run src/tools/compat/configure....


Yes that fixes it!  The build makes it past libnbcompat again!

Your original hint asking if my nbtool_config.h had:

    #define HAVE_DECL_BE64DEC 1

was the clue I should have cottoned on to!

Grrr.... HAVE_DECL_BE64ENC doesn't (just) mean "I have the declaration"
in this case!

What I also didn't realize is that compat_defs.h also contains the
_definitions_ (as inline) of the encode/decode functions copied from
<sys/endian.h> and/but that therein they are keyed on the HAVE_DECL_
results from configure.  So instead of adding more hacks to the system
headers to allow sharing those definitions we now just have to copy code
from there into the tools headers as well.  Bummer.

So anyway in 10.0 the "bug" of exposing the encode/decode definitions in
<sys/endian.h> was responsible for src/tools/compat/configure creating
output that would eventually be wrong when that bug was fixed by an
upgrade, but there's no dependency of course to tell the build to re-run
that configure when <sys/endian.h> changes.


Thank you very much for your help!

--
					Greg A. Woods <[email protected]>

Kelowna, BC     +1 250 762-7675           RoboHack <[email protected]>
Planix, Inc. <[email protected]>     Avoncote Farms <[email protected]>

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRuK6dmwVAucmRxuh9mfXG3eL/0fwUCaOd8JAAKCRBmfXG3eL/0
f9rCAKCZJrHK22caNagjEIDBRKiPTt+liACfZhi1N0o0UlK2JBiodB/Oytb9E3w=
=RiDb
-----END PGP SIGNATURE-----