Re: do people think current builds now? -- I don't

Rhialto <[email protected]> writes:

> On Fri 24 Oct 2025 at 06:53:02 -0400, Greg Troxel wrote:
>
>> So I think I had leftover .h symlinks in the *source tree* from before,
>> and cvs ignores them, but somehow they mess up the build.    I don't
>> understand why.
>
> I had an unexplained symlink in my source tree too recently, and it
> wasn't when using cvs, but with mercurial, and I noticed during a build
> after I switched branches. (But normally I build from my read-only cvs
> tree so the problem may have existed earlier)

I had 106 symlinks in src/.  This is straight CVS, just "cvs update -d
-P" with nothing odd, over a very long period of time (years), with
copies and "cvs up -r netbsd-N" once.

> I poked around a bit, but did not get to the bottom of it. What I did
> find was this Makefile fragment that looks like it could have created
> the symlinks.  It ought to be outdated if the source file actually
> existed in the repo, as it appeared to do.
>
>     src-public/external/gpl3/gcc/usr.bin/cc1objplus/Makefile
>
> which contains
>
> BUILDSYMLINKS+= ${DIST}/gcc/objc/objc-act.cc objcp-act.cc \
>                 ${DIST}/gcc/objc/objc-lang.cc objcp-lang.cc
>
> I wonder if there might be a BUILDSYMLINKS associated with your symlink
> too?

I don't find a BUILDSYMLINKS for the ones that were troublesome.

I don't undrstand why there is any code that would ever write the
srcdir.  It seems obvious to me (dangerous I know) that the sources
should always be read only (by the build system).