Re: PVH boot with qemu
Emile 'iMil' Heitor <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.kernel |
|---|---|
| Message-ID | <[email protected]> |
On 1/8/24 23:05, Manuel Bouyer wrote:
> in consinit.c you have:
>
> +#if defined(XENPVHVM) || defined(GENPVH)
> +#ifndef GENPVH
> if (vm_guest == VM_GUEST_XENPVH) {
> if (xen_pvh_consinit() != 0)
> return;
> /* fallback to native console selection, usefull for dom0 PVH */
> }
> +#endif
>
> shouldn't the #ifndef GENPVH really be #ifdef XENPVHVM ?
oh absolutely
> In the same way, the #ifndef GENPVH in xen_machdep.c should either be
> #ifdef XENPVHVM or #ifdef XEN
Indeed.
I've changed those thank you for the review!
--
------------------------------------------------------------------------
Emile `iMil' Heitor <imil@{home.imil.net,NetBSD.org}> | https://imil.net